sui_transaction_checks/

lib.rs

// Copyright (c) Mysten Labs, Inc.
// SPDX-License-Identifier: Apache-2.0

pub mod deny;

pub use checked::*;

#[sui_macros::with_checked_arithmetic]
mod checked {
    use std::collections::{BTreeMap, HashSet};
    use std::sync::Arc;
    use sui_config::verifier_signing_config::VerifierSigningConfig;
    use sui_protocol_config::ProtocolConfig;
    use sui_types::base_types::{ObjectID, ObjectRef};
    use sui_types::error::{SuiResult, UserInputError, UserInputResult};
    use sui_types::executable_transaction::VerifiedExecutableTransaction;
    use sui_types::gas::SuiGasStatusAPI;
    use sui_types::metrics::BytecodeVerifierMetrics;
    use sui_types::object::ObjectPermission;
    use sui_types::transaction::{
        CheckedInputObjects, InputObjectKind, InputObjects, ObjectReadResultKind,
        ReceivingObjectReadResult, ReceivingObjects, SharedObjectMutability, TransactionData,
        TransactionDataAPI, TransactionKind,
    };
    use sui_types::{
        SUI_ACCUMULATOR_ROOT_OBJECT_ID, SUI_ADDRESS_ALIAS_STATE_OBJECT_ID, SUI_BRIDGE_OBJECT_ID,
        SUI_CLOCK_OBJECT_ID, SUI_COIN_REGISTRY_OBJECT_ID, SUI_DENY_LIST_OBJECT_ID,
        SUI_DISPLAY_REGISTRY_OBJECT_ID, SUI_RANDOMNESS_STATE_OBJECT_ID, SUI_SYSTEM_STATE_OBJECT_ID,
    };
    use sui_types::{
        base_types::{SequenceNumber, SuiAddress},
        coin_reservation::ParsedDigest,
        error::SuiError,
        fp_bail, fp_ensure,
        gas::SuiGasStatus,
        object::{Object, Owner},
    };
    use tracing::error;
    use tracing::instrument;

    trait IntoChecked {
        fn into_checked(self) -> CheckedInputObjects;
    }

    impl IntoChecked for InputObjects {
        fn into_checked(self) -> CheckedInputObjects {
            CheckedInputObjects::new_with_checked_transaction_inputs(self)
        }
    }

    // Entry point for all checks related to gas.
    // Called on both signing and execution.
    // On success the gas part of the transaction (gas data and gas coins)
    // is verified and good to go
    fn get_gas_status(
        objects: &InputObjects,
        gas: &[ObjectRef],
        protocol_config: &ProtocolConfig,
        reference_gas_price: u64,
        transaction: &TransactionData,
        gas_ownership_checks: bool,
    ) -> SuiResult<SuiGasStatus> {
        if transaction.kind().is_system_tx() {
            Ok(SuiGasStatus::new_unmetered(protocol_config))
        } else {
            let is_gasless =
                protocol_config.enable_gasless() && transaction.is_gasless_transaction();
            check_gas(
                objects,
                protocol_config,
                reference_gas_price,
                gas,
                transaction,
                gas_ownership_checks,
                is_gasless,
            )
        }
    }

    #[instrument(level = "trace", skip_all)]
    pub fn check_transaction_input(
        protocol_config: &ProtocolConfig,
        reference_gas_price: u64,
        transaction: &TransactionData,
        input_objects: InputObjects,
        receiving_objects: &ReceivingObjects,
        metrics: &Arc<BytecodeVerifierMetrics>,
        verifier_signing_config: &VerifierSigningConfig,
    ) -> SuiResult<(SuiGasStatus, CheckedInputObjects)> {
        let gas_status = check_transaction_input_inner(
            protocol_config,
            reference_gas_price,
            transaction,
            &input_objects,
            &[],
        )?;
        transaction.check_allowance_inputs(&input_objects)?;
        check_receiving_objects(&input_objects, receiving_objects)?;
        // Runs verifier, which could be expensive.
        check_non_system_packages_to_be_published(
            transaction,
            protocol_config,
            metrics,
            verifier_signing_config,
        )?;

        Ok((gas_status, input_objects.into_checked()))
    }

    // Since the purpose of this function is to audit certified transactions,
    // the checks here should be a strict subset of the checks in check_transaction_input().
    // For checks not performed in this function but in check_transaction_input(),
    // we should add a comment calling out the difference.
    #[instrument(level = "trace", skip_all)]
    pub fn check_certificate_input(
        cert: &VerifiedExecutableTransaction,
        input_objects: InputObjects,
        protocol_config: &ProtocolConfig,
        reference_gas_price: u64,
    ) -> SuiResult<(SuiGasStatus, CheckedInputObjects)> {
        let transaction = cert.data().transaction_data();
        let gas_status = check_transaction_input_inner(
            protocol_config,
            reference_gas_price,
            transaction,
            &input_objects,
            &[],
        )?;
        // NB: We do not check receiving objects when executing. Only at signing time do we check.
        // NB: move verifier is only checked at signing time, not at execution.
        // NB: allowance withdrawal declarations are only validated at signing; at execution
        // the allowance's own Move checks enforce policy on consensus-sequenced state.

        Ok((gas_status, input_objects.into_checked()))
    }

    /// WARNING! This should only be used for the dev-inspect transaction. This transaction type
    /// bypasses many of the normal object checks
    pub fn check_dev_inspect_input(
        config: &ProtocolConfig,
        transaction: &TransactionData,
        input_objects: InputObjects,
        // TODO: check ReceivingObjects for dev inspect?
        _receiving_objects: ReceivingObjects,
        reference_gas_price: u64,
    ) -> SuiResult<(SuiGasStatus, CheckedInputObjects)> {
        let kind = transaction.kind();
        kind.validity_check(config)?;
        if kind.is_system_tx() {
            return Err(UserInputError::Unsupported(format!(
                "Transaction kind {} is not supported in dev-inspect",
                kind
            ))
            .into());
        }
        let mut used_objects: HashSet<SuiAddress> = HashSet::new();
        for input_object in input_objects.iter() {
            let Some(object) = input_object.as_object() else {
                // object was deleted
                continue;
            };

            if !object.is_immutable() {
                fp_ensure!(
                    used_objects.insert(object.id().into()),
                    UserInputError::MutableObjectUsedMoreThanOnce {
                        object_id: object.id()
                    }
                    .into()
                );
            }
        }

        let gas_status = get_gas_status(
            &input_objects,
            &transaction.gas_data().payment, //gas,
            config,
            reference_gas_price,
            transaction,
            false, // gas_ownership_checks - false means mostly transaction level checks
        )?;

        Ok((gas_status, input_objects.into_checked()))
    }

    // Common checks performed for transactions and certificates.
    fn check_transaction_input_inner(
        protocol_config: &ProtocolConfig,
        reference_gas_price: u64,
        transaction: &TransactionData,
        input_objects: &InputObjects,
        // Overrides the gas objects in the transaction.
        gas_override: &[ObjectRef],
    ) -> SuiResult<SuiGasStatus> {
        let gas = if gas_override.is_empty() {
            transaction.gas()
        } else {
            gas_override
        };

        let gas_status = get_gas_status(
            input_objects,
            gas,
            protocol_config,
            reference_gas_price,
            transaction,
            true, // gas_ownership_checks
        )?;
        check_objects(transaction, input_objects, protocol_config)?;
        check_replay_protection(transaction, input_objects)?;

        if protocol_config.enable_gasless() && transaction.is_gasless_transaction() {
            check_gasless_object_inputs(input_objects, protocol_config)?;
        }

        Ok(gas_status)
    }

    /// All transactions must have replay protection, which can come from:
    /// - ValidDuring expiration with at most two-epoch range (max_epoch = min_epoch + 1)
    /// - Owned input objects (which have unique versions/digests)
    /// - Coin reservations (which have epoch constraint like ValidDuring)
    ///
    /// This check happens here (not at validation time) because we need access to the
    /// actual objects to determine if they are owned vs immutable.
    fn check_replay_protection(
        transaction: &TransactionData,
        input_objects: &InputObjects,
    ) -> UserInputResult<()> {
        let has_replay_protection = transaction.expiration().is_replay_protected()
            || !transaction.gas_data().payment.is_empty()
            || input_objects
                .iter()
                .any(|obj| obj.is_replay_protected_input());

        if !has_replay_protection {
            return Err(UserInputError::InvalidExpiration {
                error: "Transactions must either have address-owned inputs, or a ValidDuring expiration with at most two epochs of validity"
                    .to_string(),
            });
        }

        Ok(())
    }

    fn check_receiving_objects(
        input_objects: &InputObjects,
        receiving_objects: &ReceivingObjects,
    ) -> Result<(), SuiError> {
        let mut objects_in_txn: HashSet<_> = input_objects
            .object_kinds()
            .map(|x| x.object_id())
            .collect();

        // Since we're at signing we check that every object reference that we are receiving is the
        // most recent version of that object. If it's been received at the version specified we
        // let it through to allow the transaction to run and fail to unlock any other objects in
        // the transaction. Otherwise, we return an error.
        //
        // If there are any object IDs in common (either between receiving objects and input
        // objects) we return an error.
        for ReceivingObjectReadResult {
            object_ref: (object_id, version, object_digest),
            object,
        } in receiving_objects.iter()
        {
            fp_ensure!(
                *version < SequenceNumber::MAX,
                UserInputError::InvalidSequenceNumber.into()
            );

            let Some(object) = object.as_object() else {
                // object was previously received
                continue;
            };

            if !(object.owner.is_address_owned()
                && object.version() == *version
                && object.digest() == *object_digest)
            {
                // Version mismatch
                fp_ensure!(
                    object.version() == *version,
                    UserInputError::ObjectVersionUnavailableForConsumption {
                        provided_obj_ref: (*object_id, *version, *object_digest),
                        current_version: object.version(),
                    }
                    .into()
                );

                // Tried to receive a package
                fp_ensure!(
                    !object.is_package(),
                    UserInputError::MovePackageAsObject {
                        object_id: *object_id
                    }
                    .into()
                );

                // Digest mismatch
                let expected_digest = object.digest();
                fp_ensure!(
                    expected_digest == *object_digest,
                    UserInputError::InvalidObjectDigest {
                        object_id: *object_id,
                        expected_digest
                    }
                    .into()
                );

                match object.owner {
                    Owner::AddressOwner(_) => {
                        debug_assert!(
                            false,
                            "Receiving object {:?} is invalid but we expect it should be valid. {:?}",
                            (*object_id, *version, *object_id),
                            object
                        );
                        error!(
                            "Receiving object {:?} is invalid but we expect it should be valid. {:?}",
                            (*object_id, *version, *object_id),
                            object
                        );
                        // We should never get here, but if for some reason we do just default to
                        // object not found and reject signing the transaction.
                        fp_bail!(
                            UserInputError::ObjectNotFound {
                                object_id: *object_id,
                                version: Some(*version),
                            }
                            .into()
                        )
                    }
                    Owner::ObjectOwner(owner) => {
                        fp_bail!(
                            UserInputError::InvalidChildObjectArgument {
                                child_id: object.id(),
                                parent_id: owner.into(),
                            }
                            .into()
                        )
                    }
                    Owner::Shared { .. }
                    | Owner::ConsensusAddressOwner { .. }
                    | Owner::Party { .. } => {
                        fp_bail!(UserInputError::NotSharedObjectError.into())
                    }
                    Owner::Immutable => fp_bail!(
                        UserInputError::MutableParameterExpected {
                            object_id: *object_id
                        }
                        .into()
                    ),
                };
            }

            fp_ensure!(
                !objects_in_txn.contains(object_id),
                UserInputError::DuplicateObjectRefInput.into()
            );

            objects_in_txn.insert(*object_id);
        }
        Ok(())
    }

    /// Check transaction gas data/info and gas coins consistency.
    /// Return the gas status to be used for the lifecycle of the transaction.
    #[instrument(level = "trace", skip_all)]
    fn check_gas(
        objects: &InputObjects,
        protocol_config: &ProtocolConfig,
        reference_gas_price: u64,
        gas: &[ObjectRef],
        transaction: &TransactionData,
        gas_ownership_checks: bool,
        is_gasless: bool,
    ) -> SuiResult<SuiGasStatus> {
        let gas_budget = transaction.gas_budget();
        let gas_price = transaction.gas_price();
        let gas_paid_from_address_balance = transaction.is_gas_paid_from_address_balance();

        let gas_status = if is_gasless {
            debug_assert_ne!(reference_gas_price, 0);
            let rgp = reference_gas_price.max(1);
            let compute_cap = protocol_config.gasless_max_computation_units() * rgp;
            SuiGasStatus::new(compute_cap, rgp, reference_gas_price, protocol_config)?
        } else {
            SuiGasStatus::new(gas_budget, gas_price, reference_gas_price, protocol_config)?
        };

        // check balance and coins consistency
        // load all gas coins (skip coin reservations - they're not loaded as input objects)
        let objects: BTreeMap<_, _> = objects.iter().map(|o| (o.id(), o)).collect();

        let (gas_objects, available_address_balance_gas) = if gas_paid_from_address_balance {
            // When paying from address balance via gas_data.payment = [], the budget is reserved by the scheduler
            // and guaranteed to be available.
            (vec![], gas_budget)
        } else {
            // Gas payment may include a mix of coin objects and coin reservations (withdrawals).
            // Sum up the reservation amounts separately since they don't have input objects.
            let mut available_address_balance_gas: u64 = 0;
            let mut gas_objects = vec![];
            for obj_ref in gas {
                if let Ok(parsed) = ParsedDigest::try_from(obj_ref.2) {
                    available_address_balance_gas =
                        available_address_balance_gas.saturating_add(parsed.reservation_amount());
                } else {
                    let obj = objects.get(&obj_ref.0);
                    let obj = *obj.ok_or(UserInputError::ObjectNotFound {
                        object_id: obj_ref.0,
                        version: Some(obj_ref.1),
                    })?;
                    gas_objects.push(obj);
                }
            }
            (gas_objects, available_address_balance_gas)
        };

        if !is_gasless {
            if gas_ownership_checks {
                gas_status.check_gas_objects(&gas_objects)?;
            }
            gas_status.check_gas_balance(
                &gas_objects,
                gas_budget,
                available_address_balance_gas,
            )?;
        }
        Ok(gas_status)
    }

    /// Check all the objects used in the transaction against the database, and ensure
    /// that they are all the correct version and number.
    #[instrument(level = "trace", skip_all)]
    fn check_objects(
        transaction: &TransactionData,
        objects: &InputObjects,
        protocol_config: &ProtocolConfig,
    ) -> UserInputResult<()> {
        // We require that mutable objects cannot show up more than once.
        let mut used_objects: HashSet<SuiAddress> = HashSet::new();
        for object in objects.iter() {
            if object.is_mutable() {
                fp_ensure!(
                    used_objects.insert(object.id().into()),
                    UserInputError::MutableObjectUsedMoreThanOnce {
                        object_id: object.id()
                    }
                );
            }
        }

        // When coin reservations are enabled, allow empty objects if gas is paid from
        // address balance or entirely from coin reservations (the gas coin is materialized
        // from the address balance, so no input objects are needed).
        let gas_only_contains_coin_reservations = !transaction.gas().is_empty()
            && transaction
                .gas()
                .iter()
                .all(|obj_ref| ParsedDigest::is_coin_reservation_digest(&obj_ref.2));

        let allow_empty_objects = protocol_config.enable_coin_reservation_obj_refs()
            && (transaction.is_gas_paid_from_address_balance()
                || gas_only_contains_coin_reservations);
        if !transaction.is_genesis_tx() && objects.is_empty() && !allow_empty_objects {
            return Err(UserInputError::ObjectInputArityViolation);
        }

        let gas_coins: HashSet<ObjectID> =
            HashSet::from_iter(transaction.gas().iter().map(|obj_ref| obj_ref.0));
        for object in objects.iter() {
            let input_object_kind = object.input_object_kind;

            match &object.object {
                ObjectReadResultKind::Object(object) => {
                    // For Gas Object, we check the object is owned by gas owner
                    let owner_address = if gas_coins.contains(&object.id()) {
                        transaction.gas_owner()
                    } else {
                        transaction.sender()
                    };
                    // Check if the object contents match the type of lock we need for
                    // this object.
                    let system_transaction = transaction.is_system_tx();
                    check_one_object(
                        &owner_address,
                        input_object_kind,
                        object,
                        system_transaction,
                    )?;
                }
                // We skip checking a removed consensus object because it no longer exists.
                ObjectReadResultKind::ObjectConsensusStreamEnded(_, _) => (),
                // We skip checking shared objects from cancelled transactions since we are not reading it.
                ObjectReadResultKind::CancelledTransactionSharedObject(_) => (),
            }
        }

        Ok(())
    }

    /// Check one object against a reference
    fn check_one_object(
        owner: &SuiAddress,
        object_kind: InputObjectKind,
        object: &Object,
        system_transaction: bool,
    ) -> UserInputResult {
        // Defense-in-depth: Owner::Party is not yet supported.
        if matches!(object.owner, Owner::Party { .. }) {
            return Err(UserInputError::Unsupported(
                "Party-owned objects are not yet supported".to_string(),
            ));
        }

        match object_kind {
            InputObjectKind::MovePackage(package_id) => {
                fp_ensure!(
                    object.data.try_as_package().is_some(),
                    UserInputError::MoveObjectAsPackage {
                        object_id: package_id
                    }
                );
            }
            InputObjectKind::ImmOrOwnedMoveObject((object_id, sequence_number, object_digest)) => {
                fp_ensure!(
                    !object.is_package(),
                    UserInputError::MovePackageAsObject { object_id }
                );
                fp_ensure!(
                    sequence_number < SequenceNumber::MAX,
                    UserInputError::InvalidSequenceNumber
                );

                // This is an invariant - we just load the object with the given ID and version.
                assert_eq!(
                    object.version(),
                    sequence_number,
                    "The fetched object version {} does not match the requested version {}, object id: {}",
                    object.version(),
                    sequence_number,
                    object.id(),
                );

                // Check the digest matches - user could give a mismatched ObjectDigest
                let expected_digest = object.digest();
                fp_ensure!(
                    expected_digest == object_digest,
                    UserInputError::InvalidObjectDigest {
                        object_id,
                        expected_digest
                    }
                );

                match object.owner {
                    Owner::Immutable => {
                        // Nothing else to check for Immutable.
                    }
                    Owner::AddressOwner(actual_owner) => {
                        // Check the owner is correct.
                        fp_ensure!(
                            owner == &actual_owner,
                            UserInputError::IncorrectUserSignature {
                                error: format!(
                                    "Object {object_id:?} is owned by account address {actual_owner:?}, but given owner/signer address is {owner:?}"
                                ),
                            }
                        );
                    }
                    Owner::ObjectOwner(owner) => {
                        return Err(UserInputError::InvalidChildObjectArgument {
                            child_id: object.id(),
                            parent_id: owner.into(),
                        });
                    }
                    Owner::Shared { .. }
                    | Owner::ConsensusAddressOwner { .. }
                    | Owner::Party { .. } => {
                        // This object is a mutable consensus object. However the transaction
                        // specifies it as an owned object. This is inconsistent.
                        return Err(UserInputError::NotOwnedObjectError);
                    }
                };
            }
            InputObjectKind::SharedMoveObject {
                id: object_id,
                initial_shared_version: input_initial_shared_version,
                mutability,
            } => {
                fp_ensure!(
                    object.version() < SequenceNumber::MAX,
                    UserInputError::InvalidSequenceNumber
                );

                if object_id.is_system_object() {
                    // System transactions can access system objects without further validation
                    // (e.g., AuthenticatorStateUpdate uses a placeholder initial_shared_version).
                    if system_transaction {
                        return Ok(());
                    }

                    match (object_id, mutability) {
                        // System objects that can be taken mutably
                        (SUI_SYSTEM_STATE_OBJECT_ID, _)
                        | (SUI_ADDRESS_ALIAS_STATE_OBJECT_ID, _)
                        | (SUI_COIN_REGISTRY_OBJECT_ID, _)
                        | (SUI_DISPLAY_REGISTRY_OBJECT_ID, _)
                        | (SUI_DENY_LIST_OBJECT_ID, _)
                        | (SUI_BRIDGE_OBJECT_ID, _)

                        // System objects that can only be taken immutably
                        | (SUI_CLOCK_OBJECT_ID, SharedObjectMutability::Immutable)
                        | (SUI_RANDOMNESS_STATE_OBJECT_ID, SharedObjectMutability::Immutable)
                        | (SUI_ACCUMULATOR_ROOT_OBJECT_ID, SharedObjectMutability::Immutable) => (),

                        // All other system objects: cannot be used as input at all
                        _ => {
                            return Err(UserInputError::ImmutableParameterExpectedError {
                                object_id,
                            });
                        }
                    }
                }

                match &object.owner {
                    Owner::AddressOwner(_) | Owner::ObjectOwner(_) | Owner::Immutable => {
                        // When someone locks an object as shared it must be shared already.
                        return Err(UserInputError::NotSharedObjectError);
                    }
                    Owner::Shared {
                        initial_shared_version: actual_initial_shared_version,
                    } => {
                        fp_ensure!(
                            input_initial_shared_version == *actual_initial_shared_version,
                            UserInputError::SharedObjectStartingVersionMismatch
                        )
                    }
                    Owner::ConsensusAddressOwner {
                        start_version: actual_initial_shared_version,
                        owner: actual_owner,
                    } => {
                        fp_ensure!(
                            input_initial_shared_version == *actual_initial_shared_version,
                            UserInputError::SharedObjectStartingVersionMismatch
                        );
                        // Check the owner is correct.
                        fp_ensure!(
                            owner == actual_owner,
                            UserInputError::IncorrectUserSignature {
                                error: format!(
                                    "Object {object_id:?} is owned by account address {actual_owner:?}, but given owner/signer address is {owner:?}"
                                ),
                            }
                        )
                    }

                    Owner::Party {
                        start_version: actual_initial_shared_version,
                        permissions,
                    } => {
                        fp_ensure!(
                            input_initial_shared_version == *actual_initial_shared_version,
                            UserInputError::SharedObjectStartingVersionMismatch
                        );
                        // Check the owner has permissions for this kind of mutability
                        let sender_permissions = permissions.permissions_for(owner);
                        match mutability {
                            SharedObjectMutability::Immutable => {
                                // TODO better error kind here
                                fp_ensure!(
                                    sender_permissions.can_use_immutably(),
                                    UserInputError::IncorrectUserSignature {
                                        error: format!(
                                            "Sender address {owner:?} does not have immutable access permissions for object {object_id:?} with party ownership. The required permission is {}, but the permissions for the sender for this object are {sender_permissions}",
                                            ObjectPermission::ImmutableUsage,
                                        ),
                                    }
                                )
                            }
                            SharedObjectMutability::Mutable => {
                                // TODO better error kind here
                                fp_ensure!(
                                    sender_permissions.can_use_mutably(),
                                    UserInputError::IncorrectUserSignature {
                                        error: format!(
                                            "Sender address {owner:?} does not have mutable access permissions for object {object_id:?} with party ownership. The required permission is {}, but the permissions for the sender for this object are {sender_permissions}",
                                            ObjectPermission::MutableUsage,
                                        ),
                                    }
                                )
                            }
                            SharedObjectMutability::NonExclusiveWrite => {
                                // TODO(Party WIP)
                                todo!("Party WIP")
                            }
                        }
                    }
                }
            }
        };
        Ok(())
    }

    /// Verify that all Move object inputs in a gasless transaction are `Coin<T>`
    /// where `T` is in the allowlist.
    pub fn check_gasless_object_inputs(
        input_objects: &InputObjects,
        protocol_config: &ProtocolConfig,
    ) -> UserInputResult<()> {
        let allowed_token_types =
            sui_types::transaction::get_gasless_allowed_token_types(protocol_config);

        for obj_read in input_objects.iter() {
            let Some(object) = obj_read.as_object() else {
                continue;
            };
            if object.is_package() {
                continue;
            }
            match object.owner() {
                Owner::AddressOwner(_) | Owner::ConsensusAddressOwner { .. } => (),
                Owner::Immutable
                | Owner::Shared { .. }
                | Owner::ObjectOwner(_)
                | Owner::Party { .. } => {
                    return Err(UserInputError::Unsupported(
                        "Gasless transactions only support owned object inputs".to_string(),
                    ));
                }
            }
            // Every non-package Move object input must be Coin<T> with T allowlisted
            let coin_type = object.coin_type_maybe().ok_or_else(|| {
                UserInputError::Unsupported(
                    "Gasless transactions can only use Coin<T> object inputs, \
                     but found a non-Coin object"
                        .to_string(),
                )
            })?;
            fp_ensure!(
                allowed_token_types.contains_key(&coin_type),
                UserInputError::Unsupported(
                    "Gasless transactions only support allowlisted types for Coin inputs"
                        .to_string()
                )
            );
        }
        Ok(())
    }

    /// Check package verification timeout
    #[instrument(level = "trace", skip_all)]
    pub fn check_non_system_packages_to_be_published(
        transaction: &TransactionData,
        protocol_config: &ProtocolConfig,
        metrics: &Arc<BytecodeVerifierMetrics>,
        verifier_signing_config: &VerifierSigningConfig,
    ) -> UserInputResult<()> {
        // Only meter non-system programmable transaction blocks
        if transaction.is_system_tx() {
            return Ok(());
        }

        let TransactionKind::ProgrammableTransaction(pt) = transaction.kind() else {
            return Ok(());
        };

        // Use the same verifier and meter for all packages, custom configured for signing.
        let signing_limits = Some(verifier_signing_config.limits_for_signing());
        let mut verifier = sui_execution::verifier(protocol_config, signing_limits, metrics);
        let mut meter = verifier.meter(verifier_signing_config.meter_config_for_signing());

        // Measure time for verifying all packages in the PTB
        let shared_meter_verifier_timer = metrics
            .verifier_runtime_per_ptb_success_latency
            .start_timer();

        let verifier_status = pt
            .non_system_packages_to_be_published()
            .try_for_each(|module_bytes| {
                verifier.meter_module_bytes(protocol_config, module_bytes, meter.as_mut())
            })
            .map_err(|e| UserInputError::PackageVerificationTimeout { err: e.to_string() });

        match verifier_status {
            Ok(_) => {
                // Success: stop and record the success timer
                shared_meter_verifier_timer.stop_and_record();
            }
            Err(err) => {
                // Failure: redirect the success timers output to the failure timer and
                // discard the success timer
                metrics
                    .verifier_runtime_per_ptb_timeout_latency
                    .observe(shared_meter_verifier_timer.stop_and_discard());
                return Err(err);
            }
        };

        Ok(())
    }
}