1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
// Copyright (c) 2022, Mysten Labs, Inc.
// SPDX-License-Identifier: Apache-2.0
use crate::{utils, PayloadToken};
use config::{Committee, SharedWorkerCache, WorkerId};
use consensus::dag::{Dag, ValidatorDagError};
use crypto::PublicKey;
use fastcrypto::{Digest, Hash};
use futures::{
    future::{join_all, try_join_all, BoxFuture},
    stream::{futures_unordered::FuturesUnordered, StreamExt as _},
    FutureExt,
};
use itertools::Either;
use network::{P2pNetwork, UnreliableNetwork};
use std::{collections::HashMap, sync::Arc, time::Duration};
use storage::CertificateStore;
use store::{rocks::TypedStoreError, Store};
use tokio::{
    sync::{mpsc, oneshot, watch},
    task::JoinHandle,
    time::timeout,
};
use tracing::{debug, error, info, instrument, warn};
use types::{
    metered_channel::{Receiver, Sender},
    BatchDigest, BlockRemoverError, BlockRemoverErrorKind, BlockRemoverResult, Certificate,
    CertificateDigest, Header, HeaderDigest, PrimaryWorkerMessage, ReconfigureNotification,
};

const BATCH_DELETE_TIMEOUT: Duration = Duration::from_secs(2);

type RequestKey = Vec<u8>;

#[cfg(test)]
#[path = "tests/block_remover_tests.rs"]
pub mod block_remover_tests;

#[derive(Debug)]
pub enum BlockRemoverCommand {
    RemoveBlocks {
        // the block ids to remove
        ids: Vec<CertificateDigest>,
        // the channel to communicate the results
        sender: mpsc::Sender<BlockRemoverResult<RemoveBlocksResponse>>,
    },
}

#[derive(Clone, Debug)]
pub struct RemoveBlocksResponse {
    // the block ids removed
    ids: Vec<CertificateDigest>,
}

pub type DeleteBatchResult = Result<DeleteBatchMessage, DeleteBatchMessage>;

#[derive(Clone, Default, Debug)]
pub struct DeleteBatchMessage {
    pub ids: Vec<BatchDigest>,
}

/// BlockRemover is responsible for removing blocks identified by
/// their certificate id (digest) from across our system. On high level
/// It will make sure that the DAG is updated, internal storage where
/// there certificates and headers are stored, and the corresponding
/// batches as well.
///
/// # Example
///
/// Basic setup of the BlockRemover
///
/// This example shows the basic setup of the BlockRemover module. It showcases
/// the necessary components that have to be used (e.x channels, datastore etc)
/// and how a request (command) should be issued to delete a list of blocks and receive
/// the result of it.
///
/// ```rust
/// # use store::{reopen, rocks, rocks::DBMap, Store};
/// # use network::P2pNetwork;
/// # use tokio::sync::{mpsc::{channel}, watch};
/// # use arc_swap::ArcSwap;
/// # use fastcrypto::Hash;
/// # use std::env::temp_dir;
/// # use fastcrypto::Digest;
/// # use crypto::PublicKey;
/// # use config::{Committee, WorkerCache, SharedWorkerCache};
/// # use consensus::dag::Dag;
/// # use futures::future::join_all;
/// # use narwhal_primary::{BlockRemover, BlockRemoverCommand, DeleteBatchMessage, PayloadToken};
/// # use std::collections::BTreeMap;
/// # use std::sync::Arc;
/// # use types::ReconfigureNotification;
/// # use config::WorkerId;
/// # use tempfile::tempdir;
/// # use test_utils::test_channel;
/// # use types::{Round, BatchDigest, Certificate, CertificateDigest, HeaderDigest, Header};
/// # use prometheus::Registry;
/// # use consensus::metrics::ConsensusMetrics;
/// # use storage::{CertificateStore, CertificateToken};
///
/// #[tokio::main(flavor = "current_thread")]
/// # async fn main() {
///     const CERTIFICATES_CF: &str = "certificates";
///     const CERTIFICATE_ID_BY_ROUND_CF: &str = "certificate_id_by_round";
///     const HEADERS_CF: &str = "headers";
///     const PAYLOAD_CF: &str = "payload";
///
///     let temp_dir = tempdir().expect("Failed to open temporary directory").into_path();
///
///     // Basic setup: datastore, channels & BlockWaiter
///     let rocksdb = rocks::open_cf(temp_dir, None, &[CERTIFICATES_CF, CERTIFICATE_ID_BY_ROUND_CF, HEADERS_CF, PAYLOAD_CF])
///         .expect("Failed creating database");
///
///     let (certificate_map, certificate_id_by_round_map, headers_map, payload_map) = reopen!(&rocksdb,
///             CERTIFICATES_CF;<CertificateDigest, Certificate>,
///             CERTIFICATE_ID_BY_ROUND_CF;<(Round, CertificateDigest), CertificateToken>,
///             HEADERS_CF;<HeaderDigest, Header>,
///             PAYLOAD_CF;<(BatchDigest, WorkerId), PayloadToken>);
///     let certificate_store = CertificateStore::new(certificate_map, certificate_id_by_round_map);
///     let headers_store = Store::new(headers_map);
///     let payload_store = Store::new(payload_map);
///
///     let (tx_commands, rx_commands) = test_utils::test_channel!(1);
///     let (tx_delete_batches, rx_delete_batches) = test_utils::test_channel!(1);
///     let (tx_removed_certificates, _rx_removed_certificates) = test_utils::test_channel!(1);
///     let (tx_delete_block_result, mut rx_delete_block_result) = channel(1);
///
///     let name = PublicKey::default();
///     let committee = Committee{ epoch: 0, authorities: BTreeMap::new() };
///     let worker_cache: SharedWorkerCache = WorkerCache{ epoch: 0, workers: BTreeMap::new() }.into();
///     let (_tx_reconfigure, rx_reconfigure) = watch::channel(ReconfigureNotification::NewEpoch(committee.clone()));
///     let consensus_metrics = Arc::new(ConsensusMetrics::new(&Registry::new()));
///     // A dag with genesis for the committee
///     let (tx_new_certificates, rx_new_certificates) = test_utils::test_channel!(1);
///     let dag = Arc::new(Dag::new(&committee, rx_new_certificates, consensus_metrics).1);
///     // Populate genesis in the Dag
///     join_all(
///       Certificate::genesis(&committee)
///       .iter()
///       .map(|cert| dag.insert(cert.clone())),
///     )
///     .await;
///
///     let _ = BlockRemover::spawn(
///         name,
///         committee,
///         worker_cache,
///         certificate_store.clone(),
///         headers_store.clone(),
///         payload_store.clone(),
///         Some(dag),
///         network::P2pNetwork::new(test_utils::random_network()),
///         rx_reconfigure,
///         rx_commands,
///         rx_delete_batches,
///         tx_removed_certificates,
///     );
///
///     // A dummy certificate
///     let certificate = Certificate::default();
///
///     // Send a command to receive a block
///     tx_commands
///         .send(BlockRemoverCommand::RemoveBlocks {
///             ids: vec![certificate.clone().digest()],
///             sender: tx_delete_block_result,
///         })
///         .await;
///
///     // Dummy - we expect to receive the deleted batches responses via another component
///     // and get fed via the tx_delete_batches channel.
///     tx_delete_batches.send(Ok(DeleteBatchMessage{ ids: vec![BatchDigest::default()] })).await;
///
///     // Wait to receive the blocks delete output to the provided sender channel
///     match rx_delete_block_result.recv().await {
///         Some(Ok(result)) => {
///             println!("Successfully received a delete blocks response");
///         }
///         Some(Err(err)) => {
///             println!("Received an error {:?}", err);
///         }
///         _ => {
///             println!("Nothing received");
///         }
///     }
/// # }
/// ```
pub struct BlockRemover {
    /// The public key of this primary.
    name: PublicKey,

    /// The committee information.
    committee: Committee,

    /// The worker information cache.
    worker_cache: SharedWorkerCache,

    /// Storage that keeps the Certificates by their digest id.
    certificate_store: CertificateStore,

    /// Storage that keeps the headers by their digest id
    header_store: Store<HeaderDigest, Header>,

    /// The persistent storage for payload markers from workers.
    payload_store: Store<(BatchDigest, WorkerId), PayloadToken>,

    /// The Dag structure for managing the stored certificates
    dag: Option<Arc<Dag>>,

    /// Network driver allowing to send messages.
    worker_network: P2pNetwork,

    /// Watch channel to reconfigure the committee.
    rx_reconfigure: watch::Receiver<ReconfigureNotification>,

    /// Receives the commands to execute against
    rx_commands: Receiver<BlockRemoverCommand>,

    /// Checks whether a pending request already exists
    pending_removal_requests: HashMap<RequestKey, Vec<Certificate>>,

    /// Holds the senders that are pending to be notified for
    /// a removal request.
    map_tx_removal_results:
        HashMap<RequestKey, Vec<mpsc::Sender<BlockRemoverResult<RemoveBlocksResponse>>>>,

    map_tx_worker_removal_results: HashMap<RequestKey, oneshot::Sender<DeleteBatchResult>>,

    // TODO: Change to a oneshot channel instead of an mpsc channel
    /// Receives all the responses to the requests to delete a batch.
    rx_delete_batches: Receiver<DeleteBatchResult>,

    /// Outputs all the successfully deleted certificates
    tx_removed_certificates: Sender<Certificate>,
}

impl BlockRemover {
    #[must_use]
    pub fn spawn(
        name: PublicKey,
        committee: Committee,
        worker_cache: SharedWorkerCache,
        certificate_store: CertificateStore,
        header_store: Store<HeaderDigest, Header>,
        payload_store: Store<(BatchDigest, WorkerId), PayloadToken>,
        dag: Option<Arc<Dag>>,
        worker_network: P2pNetwork,
        rx_reconfigure: watch::Receiver<ReconfigureNotification>,
        rx_commands: Receiver<BlockRemoverCommand>,
        rx_delete_batches: Receiver<DeleteBatchResult>,
        removed_certificates: Sender<Certificate>,
    ) -> JoinHandle<()> {
        tokio::spawn(async move {
            Self {
                name,
                committee,
                worker_cache,
                certificate_store,
                header_store,
                payload_store,
                dag,
                worker_network,
                rx_reconfigure,
                rx_commands,
                pending_removal_requests: HashMap::new(),
                map_tx_removal_results: HashMap::new(),
                map_tx_worker_removal_results: HashMap::new(),
                rx_delete_batches,
                tx_removed_certificates: removed_certificates,
            }
            .run()
            .await;
        })
    }

    async fn run(&mut self) {
        let mut waiting = FuturesUnordered::new();

        info!(
            "BlockRemover on node {} has started successfully.",
            self.name
        );
        loop {
            tokio::select! {
                Some(command) = self.rx_commands.recv() => {
                    if let Some(fut) = self.handle_command(command).await {
                        waiting.push(fut);
                    }
                },
                Some(batch_result) = self.rx_delete_batches.recv() => {
                    self.handle_delete_batch_result(batch_result).await;
                },
                Some(result) = waiting.next() => {
                    self.handle_remove_waiting_result(result).await;
                },
                result = self.rx_reconfigure.changed() => {
                    result.expect("Committee channel dropped");
                    let message = self.rx_reconfigure.borrow().clone();
                    match message {
                        ReconfigureNotification::NewEpoch(new_committee)=> {
                            self.worker_network.cleanup(self.committee.network_diff(&new_committee));
                            self.committee = new_committee;
                        }
                        ReconfigureNotification::UpdateCommittee(new_committee)=> {
                            self.worker_network.cleanup(self.committee.network_diff(&new_committee));
                            self.committee = new_committee;
                        }
                        ReconfigureNotification::Shutdown => return
                    }
                    tracing::debug!("Committee updated to {}", self.committee);
                }
            }
        }
    }

    async fn handle_remove_waiting_result(
        &mut self,
        result: BlockRemoverResult<RemoveBlocksResponse>,
    ) {
        let block_ids = result.clone().map_or_else(|e| e.ids, |r| r.ids);
        let key = Self::construct_blocks_request_key(&block_ids);

        match self.map_tx_removal_results.remove(&key) {
            None => {
                error!(
                    "We should expect to have a channel to send the results for key {:?}",
                    key
                );
            }
            Some(senders) => {
                let cleanup_successful = match self.pending_removal_requests.remove(&key) {
                    None => {
                        error!("Expected to find pending request for this key {:?}", &key);
                        Err(())
                    }
                    Some(certificates) => {
                        let batches_by_worker =
                            utils::map_certificate_batches_by_worker(certificates.as_slice());
                        // Clean up any possible pending result channel (e.x in case of a timeout channels are not cleaned up)
                        // So we ensure that we "unlock" the pending request and give the opportunity
                        // a request to re-execute if the downstream clean up operations fail.
                        for batch_ids in batches_by_worker.values() {
                            let request_key = Self::construct_batches_request_key(batch_ids);

                            self.map_tx_worker_removal_results.remove(&request_key);
                        }

                        // Do the further clean up only if the result is successful
                        if result.is_ok() {
                            self.cleanup_internal_state(certificates, batches_by_worker)
                                .await
                                .map_err(|_err| ())
                        } else {
                            Ok(())
                        }
                    }
                };

                // if the clean up is successful we want to send the result
                // whatever this is. Otherwise, we are sending back an error
                // response.
                if cleanup_successful.is_ok() {
                    Self::unreliable_broadcast(senders, result).await;
                } else {
                    Self::unreliable_broadcast(
                        senders,
                        Err(BlockRemoverError {
                            ids: block_ids,
                            error: BlockRemoverErrorKind::Failed,
                        }),
                    )
                    .await;
                }
            }
        }
    }

    /// Helper method to broadcast the result_to_send to all the senders.
    async fn unreliable_broadcast(
        senders: Vec<mpsc::Sender<BlockRemoverResult<RemoveBlocksResponse>>>,
        result_to_send: BlockRemoverResult<RemoveBlocksResponse>,
    ) {
        let futures: Vec<_> = senders
            .iter()
            .map(|s| s.send(result_to_send.clone()))
            .collect();

        for r in join_all(futures).await {
            if r.is_err() {
                error!("Couldn't send message to channel [{:?}]", r.err().unwrap());
            }
        }
    }

    async fn cleanup_internal_state(
        &mut self,
        certificates: Vec<Certificate>,
        batches_by_worker: HashMap<WorkerId, Vec<BatchDigest>>,
    ) -> Result<(), Either<TypedStoreError, ValidatorDagError>> {
        let header_ids: Vec<HeaderDigest> = certificates.iter().map(|c| c.header.id).collect();

        self.header_store
            .remove_all(header_ids)
            .await
            .map_err(Either::Left)?;

        // delete batch from the payload store as well
        let mut batches_to_cleanup: Vec<(BatchDigest, WorkerId)> = Vec::new();
        for (worker_id, batch_ids) in batches_by_worker {
            batch_ids.into_iter().for_each(|d| {
                batches_to_cleanup.push((d, worker_id));
            })
        }
        self.payload_store
            .remove_all(batches_to_cleanup)
            .await
            .map_err(Either::Left)?;

        // NOTE: delete certificates in the end since if we need to repeat the request
        // we want to be able to find them in storage.
        let certificate_ids: Vec<CertificateDigest> =
            certificates.as_slice().iter().map(|c| c.digest()).collect();
        if let Some(dag) = &self.dag {
            dag.remove(&certificate_ids).await.map_err(Either::Right)?
        }

        self.certificate_store
            .delete_all(certificate_ids)
            .map_err(Either::Left)?;

        // Now output all the removed certificates
        for certificate in certificates.clone() {
            self.tx_removed_certificates
                .send(certificate)
                .await
                .expect("Couldn't forward removed certificates to channel");
        }

        debug!("Successfully cleaned up certificates: {:?}", certificates);

        Ok(())
    }

    async fn handle_delete_batch_result(&mut self, batch_result: DeleteBatchResult) {
        let ids = batch_result.clone().map_or_else(|e| e.ids, |r| r.ids);
        let key = Self::construct_batches_request_key(&ids);

        if let Some(sender) = self.map_tx_worker_removal_results.remove(&key) {
            sender
                .send(batch_result)
                .expect("couldn't send delete batch result to channel");
        } else {
            error!("no pending delete request has been found for key {:?}", key);
        }
    }

    #[instrument(level = "debug", skip_all)]
    async fn handle_command<'a>(
        &mut self,
        command: BlockRemoverCommand,
    ) -> Option<BoxFuture<'a, BlockRemoverResult<RemoveBlocksResponse>>> {
        match command {
            BlockRemoverCommand::RemoveBlocks { ids, sender } => {
                // check whether we have a similar request pending
                // to make the check easy we sort the digests in asc order,
                // and then we merge all the bytes to form a key
                let key = Self::construct_blocks_request_key(&ids);

                if self.pending_removal_requests.contains_key(&key) {
                    // request already pending, nothing to do, just add the sender to the list
                    // of pending to be notified ones.
                    self.map_tx_removal_results
                        .entry(key)
                        .or_insert_with(Vec::new)
                        .push(sender);

                    debug!("Removal blocks has an already pending request for the provided ids");
                    return None;
                }

                // find the blocks in certificates store
                match self.certificate_store.read_all(ids.clone()) {
                    Ok(certificates) => {
                        let non_found_digests: Vec<CertificateDigest> = certificates
                            .iter()
                            .zip(ids.clone())
                            .filter_map(|(c, digest)| if c.is_none() { Some(digest) } else { None })
                            .collect();

                        if !non_found_digests.is_empty() {
                            warn!(
                                "Some certificates are missing, will ignore them {:?}",
                                non_found_digests
                            );
                        }

                        // ensure that we store only the found certificates
                        let found_certificates: Vec<Certificate> =
                            certificates.into_iter().flatten().collect();

                        let receivers = self
                            .send_delete_requests_to_workers(found_certificates.clone())
                            .await;

                        // now spin up a waiter
                        let fut = Self::wait_for_responses(ids, receivers);

                        // add the certificates on the pending map
                        self.pending_removal_requests
                            .insert(key.clone(), found_certificates);

                        // add the sender to the pending map
                        self.map_tx_removal_results
                            .entry(key)
                            .or_insert_with(Vec::new)
                            .push(sender);

                        return Some(fut.boxed());
                    }
                    Err(err) => {
                        error!("Error while reading certificate {:?}", err);

                        sender
                            .send(Err(BlockRemoverError {
                                ids,
                                error: BlockRemoverErrorKind::Failed,
                            }))
                            .await
                            .expect("Couldn't send error to channel");
                    }
                }
            }
        }

        None
    }

    async fn send_delete_requests_to_workers(
        &mut self,
        certificates: Vec<Certificate>,
    ) -> Vec<(RequestKey, oneshot::Receiver<DeleteBatchResult>)> {
        // For each certificate, batch the requests by worker
        // and send the requests
        let batches_by_worker = utils::map_certificate_batches_by_worker(certificates.as_slice());

        let mut receivers: Vec<(RequestKey, oneshot::Receiver<DeleteBatchResult>)> = Vec::new();

        // now send the requests
        for (worker_id, batch_ids) in batches_by_worker {
            // send the batches to each worker id
            let worker_name = self
                .worker_cache
                .load()
                .worker(&self.name, &worker_id)
                .expect("Worker id not found")
                .name;

            let message = PrimaryWorkerMessage::DeleteBatches(batch_ids.clone());

            // send the request
            let _ = self
                .worker_network
                .unreliable_send(worker_name.clone(), &message);

            debug!(
                "Sending DeleteBatches request for batch ids {:?} to worker {}",
                batch_ids.clone(),
                worker_name
            );

            // create a key based on the provided batch ids and use it as a request
            // key to identify the channel to forward the response once the delete
            // response is received.
            let worker_request_key = Self::construct_batches_request_key(&batch_ids);

            let (tx, rx) = oneshot::channel();
            receivers.push((worker_request_key.clone(), rx));

            self.map_tx_worker_removal_results
                .insert(worker_request_key, tx);
        }

        receivers
    }

    async fn wait_for_responses(
        block_ids: Vec<CertificateDigest>,
        receivers: Vec<(RequestKey, oneshot::Receiver<DeleteBatchResult>)>,
    ) -> BlockRemoverResult<RemoveBlocksResponse> {
        let waiting: Vec<_> = receivers
            .into_iter()
            .map(|p| Self::wait_for_delete_response(p.0, p.1))
            .collect();

        let result = try_join_all(waiting).await;
        if result.as_ref().is_ok() {
            return Ok(RemoveBlocksResponse { ids: block_ids });
        }

        Err(BlockRemoverError {
            ids: block_ids,
            error: result.err().unwrap(),
        })
    }

    // this method waits to receive the result to a DeleteBatchRequest. We only care to report
    // a successful delete or not. It returns true if the batches have been successfully deleted,
    // otherwise false in any other case.
    async fn wait_for_delete_response(
        request_key: RequestKey,
        rx: oneshot::Receiver<DeleteBatchResult>,
    ) -> Result<RequestKey, BlockRemoverErrorKind> {
        match timeout(BATCH_DELETE_TIMEOUT, rx).await {
            Ok(Ok(_)) => Ok(request_key),
            Ok(Err(_)) => Err(BlockRemoverErrorKind::Failed),
            Err(_) => Err(BlockRemoverErrorKind::Timeout),
        }
    }

    fn construct_blocks_request_key(ids: &[CertificateDigest]) -> RequestKey {
        let mut ids_cloned = ids.to_vec();
        ids_cloned.sort();

        // TODO: find a better way to construct request keys
        // Issue: https://github.com/MystenLabs/narwhal/issues/94

        let result: RequestKey = ids_cloned
            .into_iter()
            .flat_map(|d| Digest::from(d).to_vec())
            .collect();

        result
    }

    fn construct_batches_request_key(ids: &[BatchDigest]) -> RequestKey {
        let mut ids_cloned = ids.to_vec();
        ids_cloned.sort();

        // TODO: find a better way to construct request keys
        // Issue: https://github.com/MystenLabs/narwhal/issues/94

        let result: RequestKey = ids_cloned
            .into_iter()
            .flat_map(|d| Digest::from(d).to_vec())
            .collect();

        result
    }
}